[PATCH v2 01/13] Add new constants from Linux 6.12, 6.18 and 6.19 to bits/fcntl-linux.h

[Adhemerval Zanella Netto]

On 03/07/26 16:26, Florian Weimer wrote:
> * Adhemerval Zanella Netto:
> 
>> On 03/07/26 15:00, Adhemerval Zanella Netto wrote:
>>>
>>>
>>> On 03/07/26 14:50, Florian Weimer wrote:
>>>> * Adhemerval Zanella:
>>>>
>>>>> Add the renameat2 flags AT_RENAME_NOREPLACE, AT_RENAME_EXCHANGE and
>>>>> AT_RENAME_WHITEOUT (commit b4fef22c2fb97fa204f0c99c7c7f1c6b422ef0aa,
>>>>> Linux 6.12), FD_NSFS_ROOT (commit e83f0b5d10dcf62833008327cb661c7d118bca85,
>>>>> Linux 6.18), and F_GETDELEG and F_SETDELEG (commit
>>>>> 1602bad16d7df82faca6d7c70821117684a66f49, Linux 6.19).
>>>>> ---
>>>>>  sysdeps/unix/sysv/linux/bits/fcntl-linux.h | 8 ++++++++
>>>>>  1 file changed, 8 insertions(+)
>>>>>
>>>>> diff --git a/sysdeps/unix/sysv/linux/bits/fcntl-linux.h b/sysdeps/unix/sysv/linux/bits/fcntl-linux.h
>>>>> index 96176703274..c6e2981a179 100644
>>>>> --- a/sysdeps/unix/sysv/linux/bits/fcntl-linux.h
>>>>> +++ b/sysdeps/unix/sysv/linux/bits/fcntl-linux.h
>>>>> @@ -209,6 +209,8 @@
>>>>>  # define F_SET_RW_HINT	1036
>>>>>  # define F_GET_FILE_RW_HINT	1037
>>>>>  # define F_SET_FILE_RW_HINT	1038
>>>>> +# define F_GETDELEG	1039	/* Get delegation.  */
>>>>> +# define F_SETDELEG	1040	/* Set delegation.  */
>>>>>  #endif
>>>>>  #ifdef __USE_XOPEN2K8
>>>>>  # define F_DUPFD_CLOEXEC 1030	/* Duplicate file descriptor with
>>>>> @@ -219,6 +221,7 @@
>>>>>  #define FD_CLOEXEC	1	/* Actually anything with low bit set goes */
>>>>>  #ifdef __USE_GNU
>>>>>  # define FD_PIDFS_ROOT	-10002	/* Root of the pidfs filesystem */
>>>>> +# define FD_NSFS_ROOT	-10003	/* Root of the nsfs filesystem */
>>>>>  #endif
>>>>
>>>> Okay.
>>>>
>>>>>  #ifndef F_RDLCK
>>>>> @@ -387,6 +390,11 @@ struct file_handle
>>>>>  /* Flags for execveat2(2). */
>>>>>  # define AT_EXECVE_CHECK 0x10000 /* Only perform a check if execution
>>>>>  				    would be allowed */
>>>>> +
>>>>> +/* Flags for renameat2(2) (must match legacy RENAME_* flags).  */
>>>>> +# define AT_RENAME_NOREPLACE	0x0001 /* Don't overwrite target.  */
>>>>> +# define AT_RENAME_EXCHANGE	0x0002 /* Exchange source and dest.  */
>>>>> +# define AT_RENAME_WHITEOUT	0x0004 /* Whiteout source.  */
>>>>>  #endif
>>>>
>>>> Duplication vs. libio/stdio.h?
>>> Sigh, forgot that we have already added them.  I need to update my scripts.
>>> I will remove them.
>>
>> Are you ok with this removed or should I send a new version?
> 
> With the removal:
> 
> Reviewed-by: Florian Weimer <fweimer@redhat.com>
> 
Thanks, I think the only missing patch review  in this serie is the aarch64 
hwcap one [1].

[1] https://patchwork.sourceware.org/project/glibc/patch/20260703145150.276144-4-adhemerval.zanella@linaro.org/