[PATCH 1/4] support: Fix memory leaks in support_subprogram, support_subprogram_wait

Adhemerval Zanella Netto adhemerval.zanella@linaro.org
Wed Jan 21 15:48:20 GMT 2026


LGTM, thanks.

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

On 20/01/26 17:57, Florian Weimer wrote:
> ---
>  support/support_subprocess.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/support/support_subprocess.c b/support/support_subprocess.c
> index 32eeeecdd5..5a81163bb6 100644
> --- a/support/support_subprocess.c
> +++ b/support/support_subprocess.c
> @@ -89,6 +89,7 @@ support_subprogram (const char *file, char *const argv[], char *const envp[])
>  
>    result.pid = xposix_spawn (file, &fa, NULL, argv,
>  			     envp == NULL ? environ : envp);
> +  posix_spawn_file_actions_destroy (&fa);
>  
>    xclose (result.stdout_pipe[1]);
>    xclose (result.stderr_pipe[1]);
> @@ -105,6 +106,7 @@ support_subprogram_wait (const char *file, char *const argv[])
>    struct support_subprocess res = support_subprocess_init ();
>  
>    res.pid = xposix_spawn (file, &fa, NULL, argv, environ);
> +  posix_spawn_file_actions_destroy (&fa);
>  
>    return support_process_wait (&res);
>  }



More information about the Libc-alpha mailing list