[PATCH] Don't include <bits/openat2.h> directly (bug 33848)
Adhemerval Zanella Netto
adhemerval.zanella@linaro.org
Tue Feb 3 13:38:27 GMT 2026
On 03/02/26 09:28, Florian Weimer wrote:
> * Andreas Schwab:
>
>> Headers from bits directories should never be included directly, only via
>> the official headers.
>> ---
>> sysdeps/unix/sysv/linux/openat2.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/sysdeps/unix/sysv/linux/openat2.c b/sysdeps/unix/sysv/linux/openat2.c
>> index 7587dd577a..ac7b70584e 100644
>> --- a/sysdeps/unix/sysv/linux/openat2.c
>> +++ b/sysdeps/unix/sysv/linux/openat2.c
>> @@ -17,7 +17,6 @@
>> <https://www.gnu.org/licenses/>. */
>>
>> #include <fcntl.h>
>> -#include <bits/openat2.h>
>> #include <sysdep-cancel.h>
>>
>> int
>
> Seems reasonable based on what I saw when I investigated the bug.
>
> Reviewed-by: Florian Weimer <fweimer@redhat.com>
>
> Thanks,
> Florian
>
Ok, although I am still puzzled why we haven't see it on multiple builds with
different gcc and kernel versions.
More information about the Libc-alpha
mailing list