[PATCH] sysdeps: Fix comment typos in sysdeps/unix/sysdep.h
Collin Funk
collin.funk1@gmail.com
Sat Aug 1 17:54:07 GMT 2026
Ryota Saito <saito.ryota.23@shizuoka.ac.jp> writes:
> Fix grammar in the comments describing __SYSCALL_CANCEL_CALL and
> __INTERNAL_SYSCALL_CANCEL_CALL.
> ---
> sysdeps/unix/sysdep.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sysdeps/unix/sysdep.h b/sysdeps/unix/sysdep.h
> index a6ce5348ec..365c582296 100644
> --- a/sysdeps/unix/sysdep.h
> +++ b/sysdeps/unix/sysdep.h
> @@ -199,8 +199,8 @@ long int __syscall_cancel (__syscall_arg_t arg1, __syscall_arg_t arg2,
> #define __SYSCALL_CANCEL_DISP(b,...) \
> __SYSCALL_CANCEL_CONCAT (b,__SYSCALL_CANCEL_NARGS(__VA_ARGS__))(__VA_ARGS__)
>
> -/* Issue a cancellable syscall defined first argument plus any other argument
> - required. If and error occurs its value, the macro returns -1 and sets
> +/* Issue a cancellable syscall defined by the first argument plus any other
> + argument required. If an error occurs, the macro returns -1 and sets
> errno accordingly. */
> #define __SYSCALL_CANCEL_CALL(...) \
> __SYSCALL_CANCEL_DISP (__SYSCALL_CANCEL, __VA_ARGS__)
> @@ -235,7 +235,7 @@ long int __syscall_cancel (__syscall_arg_t arg1, __syscall_arg_t arg2,
> __SSC (a7), __NR_##name)
>
> /* Issue a cancellable syscall defined by syscall number NAME plus any other
> - argument required. If an error occurs its value is returned as an negative
> + argument required. If an error occurs its value is returned as a negative
> number unmodified and errno is not set. */
> #define __INTERNAL_SYSCALL_CANCEL_CALL(...) \
> __SYSCALL_CANCEL_DISP (__INTERNAL_SYSCALL_CANCEL, __VA_ARGS__)
Looks obvious to me. Before I commit it, can I add a "Signed-off-by" to
make it clear that it is not covered by an assignment and that you have
read the DCO [1]?
Other than that:
Reviewed-by: Collin Funk <collin.funk1@gmail.com>
Collin
[1] https://sourceware.org/glibc/wiki/Contribution%20checklist#Copyright_and_license
More information about the Libc-alpha
mailing list