[PATCH] s390: Remove Wno-CFLAGS for rtld.c/dl-load.c/dl-reloc.c
Florian Weimer
fweimer@redhat.com
Tue Apr 21 12:52:33 GMT 2026
* Stefan Liebler:
> While review of s390-32 removal, Adhemerval asked if those CFLAGS are still
> necessary:
> https://inbox.sourceware.org/libc-alpha/20260409085102.3475867-1-stli@linux.ibm.com/T/#me5120906445f3941031e29c3a093f1699eae77b4
>
> According to the git-history, the first s390-Makefile was introduced back in
> 2000-08-02 with those CFLAGS. The same are also included now and past in
> i386-Makefile. But I haven't found a reason why those were added in the past
> and if it was really necessary on s390. I assume it was with old GCCs most
> likely due to inclusion of dl-machine.h.
>
> This patch removes those CFLAGS. If needed, we have to circumvent the issues
> again. At least I've used current GCCs 12.5, 13.4, 14.3, 15.2 and gcc-head
> to successfully build current glibc on s390-64 with -O2, -O3 and -Os without
> such warnings.
> ---
> sysdeps/s390/Makefile | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/sysdeps/s390/Makefile b/sysdeps/s390/Makefile
> index 29d11dfdab..85446ca0b3 100644
> --- a/sysdeps/s390/Makefile
> +++ b/sysdeps/s390/Makefile
> @@ -47,10 +47,6 @@ $(modpfx)gconv-modules-s390.conf: ../sysdeps/s390/gconv-modules-s390.conf \
> endif
>
> ifeq ($(subdir),elf)
> -CFLAGS-rtld.c += -Wno-uninitialized -Wno-unused
> -CFLAGS-dl-load.c += -Wno-unused
> -CFLAGS-dl-reloc.c += -Wno-unused
> -
> $(objpfx)tst-glibc-hwcaps: \
> $(objpfx)libmarkermod2-1.so \
> $(objpfx)libmarkermod3-1.so \
Looks okay, thanks.
Reviewed-by: Florian Weimer <fweimer@redhat.com>
Florian
More information about the Libc-alpha
mailing list