[PATCH] Fix 'cbaud_to_speed' defined but not used on LA32

[H.J. Lu]

On Mon, Apr 20, 2026 at 10:04 AM mengqinggang <mengqinggang@loongson.cn> wrote:
>
>
> 在 2026/4/15 22:20, Adhemerval Zanella Netto 写道:
> >
> > On 23/03/26 04:16, mengqinggang wrote:
> >> cbaud_to_speed defined without condition, but used
> >> if TEST_COMPAT (libc, GLIBC_2_0, GLIBC_2_42)
> >>
> >> If the condition is not met, a defined but not used
> >> warning will be issued.
> >>
> >> Define cbaud_to_speed if TEST_COMPAT (libc, GLIBC_2_0, GLIBC_2_42)
> >> is true.
> > LGTM, thanks.
> >
> > Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
>
>
> Could you please help push to the master branch.

Done.

>
> Thanks,
> Meng
>
>
> >> ---
> >>   sysdeps/unix/sysv/linux/tst-termios-linux.c | 24 ++++++++++-----------
> >>   1 file changed, 12 insertions(+), 12 deletions(-)
> >>
> >> diff --git a/sysdeps/unix/sysv/linux/tst-termios-linux.c b/sysdeps/unix/sysv/linux/tst-termios-linux.c
> >> index 6495b435e8..d9c3284e1c 100644
> >> --- a/sysdeps/unix/sysv/linux/tst-termios-linux.c
> >> +++ b/sysdeps/unix/sysv/linux/tst-termios-linux.c
> >> @@ -163,18 +163,6 @@ static speed_t speed_to_cbaud (speed_t speed)
> >>     return ct->cbaud;
> >>   }
> >>
> >> -/* Returns ANY if cbaud is __BOTHER, or BOGUS if invalid */
> >> -static speed_t cbaud_to_speed (speed_t cbaud)
> >> -{
> >> -  const struct cbaud_table *ct;
> >> -  for (ct = cbaud_table; ct->cbaud != BOGUS; ct++)
> >> -    {
> >> -      if (ct->cbaud == cbaud)
> >> -    break;
> >> -    }
> >> -  return ct->speed;
> >> -}
> >> -
> >>   static const char *cbaud_name (speed_t cbaud)
> >>   {
> >>     const struct cbaud_table *ct;
> >> @@ -514,6 +502,18 @@ old_tcspeed_test (int fd, speed_t speed)
> >>     check_speeds_tc (fd, speed, speed);
> >>   }
> >>
> >> +/* Returns ANY if cbaud is __BOTHER, or BOGUS if invalid */
> >> +static speed_t cbaud_to_speed (speed_t cbaud)
> >> +{
> >> +  const struct cbaud_table *ct;
> >> +  for (ct = cbaud_table; ct->cbaud != BOGUS; ct++)
> >> +    {
> >> +      if (ct->cbaud == cbaud)
> >> +    break;
> >> +    }
> >> +  return ct->speed;
> >> +}
> >> +
> >>   /* Verify that invalid CBAUD values return error for the old interfaces */
> >>   static void
> >>   old_invalid_speeds_test (int fd)
>


-- 
H.J.