[PATCH v5 0/3] Re: [PATCH v4 2/2] stdio-common: Fix buffer overflow in scanf %mc [BZ #34008]

[Carlos O'Donell]

On 4/13/26 10:17 PM, Rocket Ma wrote:
> One commit for regression, one commit to directly fix the overflow, and
> one commit to refactor array expansion.
> 
> Rocket Ma (3):
>    stdio-common: Add regression test [BZ #34008]
>    stdio-common: Fix buffer overflow in scanf %mc [BZ #34008]

May you please fold these two into one commit and post that as v6 resolving #34008?

If you split the regression test into one commit it breaks bisecting.

With the test first someone who is bisecting will see the failure immediately show up.

With the test and fix together every commit in the tree keeps the testsuite clean.

>    stdio-common: Optimize %ms expansion for best fit

This we can handle as a distinct followup patch.

Please post this again after we've merged the fix for 34008?

Thank you!
  
>   stdio-common/Makefile              |  4 ++
>   stdio-common/tst-vfscanf-bz34008.c | 48 ++++++++++++++++++++
>   stdio-common/vfscanf-internal.c    | 70 +++++++++++++++++++-----------
>   3 files changed, 97 insertions(+), 25 deletions(-)
>   create mode 100644 stdio-common/tst-vfscanf-bz34008.c
> 




-- 
Cheers,
Carlos.