[PATCH v2 1/2] x86: Remove obsolete "*&" GCC asm memory operand workaround

Uros Bizjak ubizjak@gmail.com
Wed Sep 24 05:57:13 GMT 2025


On Tue, Sep 23, 2025 at 10:20 PM Joseph Myers <josmyers@redhat.com> wrote:
>
> On Sun, 21 Sep 2025, Uros Bizjak wrote:
>
> > diff --git a/sysdeps/x86/fpu_control.h b/sysdeps/x86/fpu_control.h
> > index 967e8ca5c3..e8c08de9d5 100644
> > --- a/sysdeps/x86/fpu_control.h
> > +++ b/sysdeps/x86/fpu_control.h
> > @@ -89,7 +89,7 @@
> >  /* Type of the control word.  */
> >  typedef unsigned int fpu_control_t __attribute__ ((__mode__ (__HI__)));
> >
> > -/* Macros for accessing the hardware control word.  "*&" is used to
> > +/* Macros for accessing the hardware control word.  "" is used to
> >     work around a bug in older versions of GCC.  __volatile__ is used
>
> Saying '"" is used to work around' doesn't make sense, and fpu_control.h
> is an installed header so a wider range of compiler versions (including
> ones older than GCC 9) are relevant with it than are relevant for building
> glibc.

"" is a case of too eager sed script... But if this is an installed
header, I'll revert this part.

Thanks,
Uros.


More information about the Libc-alpha mailing list