[PATCH v2] nptl: Fix MADV_GUARD_INSTALL logic for thread without guard page (BZ 33356)

Florian Weimer fweimer@redhat.com
Mon Sep 22 08:19:55 GMT 2025


* Adhemerval Zanella:

> diff --git a/nptl/tst-guard1.c b/nptl/tst-guard1.c
> index e3e06df0fc..027c282a04 100644
> --- a/nptl/tst-guard1.c
> +++ b/nptl/tst-guard1.c

>    static const struct {
>      const char *descr;
> -    void (*test)(void);
> +    void (*test)(void *);

Missing space before second '('.

> +  /* Run each test with a clean state.  */
> +  for (int i = 0; i < array_length (tests); i++)
> +    {
> +      printf ("debug: fork: test%01d: %s\n", i, tests[i].descr);
> +      struct support_capture_subprocess result =
> +	support_capture_subprocess (tests[i].test, NULL);
> +      support_capture_subprocess_check (&result, tests[i].descr, 0, sc_allow_none);

This line is overly long.

Okay with the above nits fixed.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian



More information about the Libc-alpha mailing list