[PATCH] x86: Clean up and improve FPU inline assembly

Adhemerval Zanella Netto adhemerval.zanella@linaro.org
Fri Sep 19 18:40:40 GMT 2025



On 19/09/25 15:35, Florian Weimer wrote:
> * Uros Bizjak:
> 
>> Clean up and improve x86 FPU inline assembly:
>>
>>   * Remove obsolete "*&" GCC asm memory operand workaround
>>
>>   * Use %v prefix to emit VEX prefixed insns for AVX targets
>>
>>   * Use \t and \n\t separators consistently
>>
>> Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
> 
> Reviewed-by: Florian Weimer <fweimer@redhat.com>
> 
> I'm not particularly fond of the \t, but I probably won't change any of
> this code, so it doesn't matter to me.

I would prefer we drop it, since it makes history a bit harder to
follow.

> 
> The %v changes make the VEX prefix more consistent.  I suppose that's
> okay.  But it's puzzling to me my the VEX variant is advantageous, given
> that its encoding is one byte longer.  I wouldn't consider it a SIMD
> instruction, so the VEX vs legacy mixing shouldn't apply?
> 
> Thanks,
> Florian
> 



More information about the Libc-alpha mailing list