[PATCH v3 6/6] mips: Fix delay slot filling in bsd-setjmp.S
Adhemerval Zanella Netto
adhemerval.zanella@linaro.org
Wed Sep 17 21:36:03 GMT 2025
On 03/09/25 10:53, Jovan Dmitrovic wrote:
> In the !defined __PIC__ case, we cannot guarantee that the delay slot
> is properly filled at the final `j` instuction without reordering
> active.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> sysdeps/mips/bsd-setjmp.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/mips/bsd-setjmp.S b/sysdeps/mips/bsd-setjmp.S
> index b8f5ef6ca7..4d638216d2 100644
> --- a/sysdeps/mips/bsd-setjmp.S
> +++ b/sysdeps/mips/bsd-setjmp.S
> @@ -28,8 +28,8 @@
> .option pic2
> #endif
> ENTRY (setjmp)
> - .set noreorder
> #ifdef __PIC__
> + .set noreorder
> .cpload t9
> .set reorder
> la t9, C_SYMBOL_NAME (__sigsetjmp)
More information about the Libc-alpha
mailing list