[PATCH 14/25] math: Use acosh from CORE-MATH

Adhemerval Zanella Netto adhemerval.zanella@linaro.org
Mon Sep 15 17:00:45 GMT 2025



On 09/09/25 23:58, DJ Delorie wrote:
> Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:
> 
>> +			       -0x1.1bf173531ee23p-23, 0x1.613229230e255p-25 };
> 
> This line is dangerously close to 80 columns...

Ack.  For this file, and for the other as well, I used clang-format along with
our .clang-format.  It seems that it still have some corner cases it does not
handle well.

> 
>> +    static
>> +    __attribute__ ((noinline)) double as_acosh_database (double x, double f)
> 
> Stylistically, this should be:
> 
>> +    static __attribute__ ((noinline)) double
>> +    as_acosh_database (double x, double f)

Ack.

> 
> 
>> +  if (ix < 0x4190000000000000)
> 
> Do we need a UL suffix here (and other places)?
> 

I will used UINT64_C consistently.


More information about the Libc-alpha mailing list