[PATCH 2/2] stdlib: Use support_accept_oom in test-bz22786

Carlos O'Donell carlos@redhat.com
Tue Sep 9 12:26:41 GMT 2025


On 6/3/25 12:46 PM, Florian Weimer wrote:
> The realpath call may trigger OOM termination of the test process
> under difficult-to-predict circumstances.  (It depends on available
> RAM and swap.)  Therefore, instruct the test driver to ignore
> an OOM process termination during the realpath call.

Agreed, test-bz22786 can use a lot of memory.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

> ---
>   stdlib/test-bz22786.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/stdlib/test-bz22786.c b/stdlib/test-bz22786.c
> index e2dbae74d4..3db8590101 100644
> --- a/stdlib/test-bz22786.c
> +++ b/stdlib/test-bz22786.c
> @@ -60,8 +60,11 @@ do_test (void)
>     *(p++) = '/';
>     p[path_len - (p - path) - 1] = '\0';
>   
> -  /* This call crashes before the fix for bz22786 on 32-bit platforms.  */
> +  /* This call crashes before the fix for bz22786 on 32-bit platforms.
> +     It may trigger an OOM event. */
> +  support_accept_oom (true);
>     p = realpath (path, NULL);
> +  support_accept_oom (false);

OK. These convert OOM to UNSUPPORTED for the test if there isn't enough memory.

>     TEST_VERIFY (p == NULL);
>     /* For 64-bit platforms readlink return ENAMETOOLONG, while for 32-bit
>        realpath will try to allocate a buffer larger than PTRDIFF_MAX.  */


-- 
Cheers,
Carlos.



More information about the Libc-alpha mailing list