[PATCH 40/59] elf: Only defines _dl_tls_allocate_active for SHARED

Sam James sam@gentoo.org
Sat Oct 18 06:40:31 GMT 2025


Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:

> clang issues:

s/defines/defined/ in summary

>
> dl-tls.c:108:1: error: unused function '_dl_tls_allocate_active' [-Werror,-Wunused-function]
>   108 | _dl_tls_allocate_active (void)
>       | ^~~~~~~~~~~~~~~~~~~~~~~
> 1 error generated.


Reviewed-by: Sam James <sam@gentoo.org>

> ---
>  elf/dl-tls.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/elf/dl-tls.c b/elf/dl-tls.c
> index a083a82933..aacd80cbe5 100644
> --- a/elf/dl-tls.c
> +++ b/elf/dl-tls.c
> @@ -103,11 +103,13 @@ _dl_tls_allocate_end (void)
>    atomic_fetch_add_relaxed (&_dl_tls_threads_in_update, -1);
>  }
>  
> +#ifdef SHARED
>  static inline bool
>  _dl_tls_allocate_active (void)
>  {
>    return atomic_load_relaxed (&_dl_tls_threads_in_update) > 0;
>  }
> +#endif
>  
>  /* Compute the static TLS surplus based on the namespace count and the
>     TLS space that can be used for optimizations.  */


More information about the Libc-alpha mailing list