[PATCH v5] string: Add tests for unique strerror and strsignal strings

[Florian Weimer]

* Arjun Shankar:

> +# These tests need to access glibc's internal error list
> +CFLAGS-tst-strerror-strings.c += -I../stdio-common
> +CFLAGS-tst-strerror_l-strings.c += -I../stdio-common
> +CFLAGS-tst-strerror_r-strings.c += -I../stdio-common
> +CFLAGS-tst-strerrordesc_np-strings.c += -I../stdio-common
> +CFLAGS-tst-xsi-strerror_r-strings.c += -I../stdio-common
> +endif # $(subdir) == string

We generally write $(..) for the top-level directory in makefiles.

Or maybe

#include <stdio-common/errlist.h>

works?

Another option would be to move the new tests into stdio-common.

> +      /* Mostly known errors.  Might have "holes" (unused errnums) in the set.  */

This line is too long.

> +        TEST_VERIFY_EXIT (strstr (sig_str[i], "Unknown signal ") == sig_str[i]);

Likewise.

> +        TEST_VERIFY_EXIT (strstr (sig_str[i], "Real-time signal ") == sig_str[i]);

Likewise.

Thanks,
Florian