[PATCH v4 15/21] math: Remove the SVID error handling from coshf
Adhemerval Zanella
adhemerval.zanella@linaro.org
Wed Oct 8 13:55:15 GMT 2025
It improves latency for about 3-10% and throughput for about 5-15%.
Tested on x86_64-linux-gnu and i686-linux-gnu.
---
math/Versions | 2 +-
math/w_coshf_compat.c | 12 +++++++++---
sysdeps/ieee754/flt-32/e_coshf.c | 11 ++++++++++-
sysdeps/ieee754/flt-32/w_coshf.c | 1 +
sysdeps/m68k/m680x0/fpu/w_coshf_compat.c | 8 ++++++++
sysdeps/mach/hurd/i386/libm.abilist | 1 +
sysdeps/unix/sysv/linux/aarch64/libm.abilist | 1 +
sysdeps/unix/sysv/linux/alpha/libm.abilist | 1 +
sysdeps/unix/sysv/linux/arm/be/libm.abilist | 1 +
sysdeps/unix/sysv/linux/arm/le/libm.abilist | 1 +
sysdeps/unix/sysv/linux/hppa/libm.abilist | 1 +
sysdeps/unix/sysv/linux/i386/libm.abilist | 1 +
sysdeps/unix/sysv/linux/m68k/coldfire/libm.abilist | 1 +
sysdeps/unix/sysv/linux/microblaze/be/libm.abilist | 1 +
sysdeps/unix/sysv/linux/microblaze/le/libm.abilist | 1 +
sysdeps/unix/sysv/linux/mips/mips32/libm.abilist | 1 +
sysdeps/unix/sysv/linux/mips/mips64/libm.abilist | 1 +
.../sysv/linux/powerpc/powerpc32/fpu/libm.abilist | 1 +
.../sysv/linux/powerpc/powerpc32/nofpu/libm.abilist | 1 +
.../sysv/linux/powerpc/powerpc64/be/libm.abilist | 1 +
.../sysv/linux/powerpc/powerpc64/le/libm.abilist | 1 +
sysdeps/unix/sysv/linux/s390/s390-32/libm.abilist | 1 +
sysdeps/unix/sysv/linux/s390/s390-64/libm.abilist | 1 +
sysdeps/unix/sysv/linux/sh/be/libm.abilist | 1 +
sysdeps/unix/sysv/linux/sh/le/libm.abilist | 1 +
sysdeps/unix/sysv/linux/sparc/sparc32/libm.abilist | 1 +
sysdeps/unix/sysv/linux/sparc/sparc64/libm.abilist | 1 +
sysdeps/unix/sysv/linux/x86_64/64/libm.abilist | 1 +
sysdeps/unix/sysv/linux/x86_64/x32/libm.abilist | 1 +
29 files changed, 53 insertions(+), 5 deletions(-)
create mode 100644 sysdeps/ieee754/flt-32/w_coshf.c
create mode 100644 sysdeps/m68k/m680x0/fpu/w_coshf_compat.c
diff --git a/math/Versions b/math/Versions
index e0430d8ecc7..3a300b3cb53 100644
--- a/math/Versions
+++ b/math/Versions
@@ -689,6 +689,6 @@ libm {
GLIBC_2.43 {
# No SVID compatible error handling.
remainderf; remainder; log10f; lgammaf; lgammaf_r; acosf; asinf; acoshf;
- atan2f; atanhf;
+ atan2f; atanhf; coshf;
}
}
diff --git a/math/w_coshf_compat.c b/math/w_coshf_compat.c
index ce5e196c078..bef703becd8 100644
--- a/math/w_coshf_compat.c
+++ b/math/w_coshf_compat.c
@@ -20,10 +20,11 @@
#include <math_private.h>
#include <math-svid-compat.h>
#include <libm-alias-float.h>
+#include <shlib-compat.h>
-#if LIBM_SVID_COMPAT
+#if LIBM_SVID_COMPAT && SHLIB_COMPAT (libm, GLIBC_2_0, GLIBC_2_43)
float
-__coshf (float x)
+__cosh_compatf (float x)
{
float z = __ieee754_coshf (x);
if (__builtin_expect (!isfinite (z), 0) && isfinite (x)
@@ -32,5 +33,10 @@ __coshf (float x)
return z;
}
-libm_alias_float (__cosh, cosh)
+# ifdef NO_COMPAT_NEEDED
+strong_alias (__cosh_compatf, __coshf)
+libm_alias_float (__cosh_compat, cosh)
+# else
+compat_symbol (libm, __cosh_compatf, coshf, GLIBC_2_0);
+# endif
#endif
diff --git a/sysdeps/ieee754/flt-32/e_coshf.c b/sysdeps/ieee754/flt-32/e_coshf.c
index 382cd55cdf0..4ef05133609 100644
--- a/sysdeps/ieee754/flt-32/e_coshf.c
+++ b/sysdeps/ieee754/flt-32/e_coshf.c
@@ -27,11 +27,13 @@ SOFTWARE.
#include <stdint.h>
#include <math.h>
#include <libm-alias-finite.h>
+#include <libm-alias-float.h>
+#include <math-svid-compat.h>
#include "math_config.h"
#include "e_sincoshf_data.h"
float
-__ieee754_coshf (float x)
+__coshf (float x)
{
const double iln2 = 0x1.71547652b82fep+5;
double z = x;
@@ -92,4 +94,11 @@ __ieee754_coshf (float x)
}
return ub;
}
+strong_alias (__coshf, __ieee754_coshf)
+#if LIBM_SVID_COMPAT
+versioned_symbol (libm, __coshf, coshf, GLIBC_2_43);
+libm_alias_float_other (__cosh, cosh)
+#else
+libm_alias_float (__cosh, cosh)
+#endif
libm_alias_finite (__ieee754_coshf, __coshf)
diff --git a/sysdeps/ieee754/flt-32/w_coshf.c b/sysdeps/ieee754/flt-32/w_coshf.c
new file mode 100644
index 00000000000..1cc89317007
--- /dev/null
+++ b/sysdeps/ieee754/flt-32/w_coshf.c
@@ -0,0 +1 @@
+/* Not needed. */
diff --git a/sysdeps/m68k/m680x0/fpu/w_coshf_compat.c b/sysdeps/m68k/m680x0/fpu/w_coshf_compat.c
new file mode 100644
index 00000000000..14444a9f0cb
--- /dev/null
+++ b/sysdeps/m68k/m680x0/fpu/w_coshf_compat.c
@@ -0,0 +1,8 @@
+/* m68k provides an optimized __ieee754_coshhf. */
+#ifdef SHARED
+# define NO_COMPAT_NEEDED 1
+# include <math/w_coshf_compat.c>
+#else
+# include <math-type-macros-float.h>
+# include <w_cosh_template.c>
+#endif
diff --git a/sysdeps/mach/hurd/i386/libm.abilist b/sysdeps/mach/hurd/i386/libm.abilist
index ebca620a208..2d288a54b46 100644
--- a/sysdeps/mach/hurd/i386/libm.abilist
+++ b/sysdeps/mach/hurd/i386/libm.abilist
@@ -1322,6 +1322,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 fmod F
GLIBC_2.43 fmodf F
GLIBC_2.43 lgammaf F
diff --git a/sysdeps/unix/sysv/linux/aarch64/libm.abilist b/sysdeps/unix/sysv/linux/aarch64/libm.abilist
index 5babbf43ec0..200df498d95 100644
--- a/sysdeps/unix/sysv/linux/aarch64/libm.abilist
+++ b/sysdeps/unix/sysv/linux/aarch64/libm.abilist
@@ -1290,6 +1290,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/alpha/libm.abilist b/sysdeps/unix/sysv/linux/alpha/libm.abilist
index d68f87f7af4..dfa684376f3 100644
--- a/sysdeps/unix/sysv/linux/alpha/libm.abilist
+++ b/sysdeps/unix/sysv/linux/alpha/libm.abilist
@@ -1449,6 +1449,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/arm/be/libm.abilist b/sysdeps/unix/sysv/linux/arm/be/libm.abilist
index 4c3be38bae2..ae81903d355 100644
--- a/sysdeps/unix/sysv/linux/arm/be/libm.abilist
+++ b/sysdeps/unix/sysv/linux/arm/be/libm.abilist
@@ -955,6 +955,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/arm/le/libm.abilist b/sysdeps/unix/sysv/linux/arm/le/libm.abilist
index 4c3be38bae2..ae81903d355 100644
--- a/sysdeps/unix/sysv/linux/arm/le/libm.abilist
+++ b/sysdeps/unix/sysv/linux/arm/le/libm.abilist
@@ -955,6 +955,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/hppa/libm.abilist b/sysdeps/unix/sysv/linux/hppa/libm.abilist
index e79d15858e7..91dc1148162 100644
--- a/sysdeps/unix/sysv/linux/hppa/libm.abilist
+++ b/sysdeps/unix/sysv/linux/hppa/libm.abilist
@@ -955,6 +955,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/i386/libm.abilist b/sysdeps/unix/sysv/linux/i386/libm.abilist
index 0aae5749431..975d6878ab0 100644
--- a/sysdeps/unix/sysv/linux/i386/libm.abilist
+++ b/sysdeps/unix/sysv/linux/i386/libm.abilist
@@ -1329,6 +1329,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 fmod F
GLIBC_2.43 fmodf F
GLIBC_2.43 lgammaf F
diff --git a/sysdeps/unix/sysv/linux/m68k/coldfire/libm.abilist b/sysdeps/unix/sysv/linux/m68k/coldfire/libm.abilist
index 4c3be38bae2..ae81903d355 100644
--- a/sysdeps/unix/sysv/linux/m68k/coldfire/libm.abilist
+++ b/sysdeps/unix/sysv/linux/m68k/coldfire/libm.abilist
@@ -955,6 +955,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/microblaze/be/libm.abilist b/sysdeps/unix/sysv/linux/microblaze/be/libm.abilist
index 733fa068e16..358b838b6cb 100644
--- a/sysdeps/unix/sysv/linux/microblaze/be/libm.abilist
+++ b/sysdeps/unix/sysv/linux/microblaze/be/libm.abilist
@@ -955,6 +955,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/microblaze/le/libm.abilist b/sysdeps/unix/sysv/linux/microblaze/le/libm.abilist
index 733fa068e16..358b838b6cb 100644
--- a/sysdeps/unix/sysv/linux/microblaze/le/libm.abilist
+++ b/sysdeps/unix/sysv/linux/microblaze/le/libm.abilist
@@ -955,6 +955,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/mips/mips32/libm.abilist b/sysdeps/unix/sysv/linux/mips/mips32/libm.abilist
index 59d9fc927e9..7b866d32a79 100644
--- a/sysdeps/unix/sysv/linux/mips/mips32/libm.abilist
+++ b/sysdeps/unix/sysv/linux/mips/mips32/libm.abilist
@@ -955,6 +955,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/mips/mips64/libm.abilist b/sysdeps/unix/sysv/linux/mips/mips64/libm.abilist
index f3c3f357816..1e9129b6356 100644
--- a/sysdeps/unix/sysv/linux/mips/mips64/libm.abilist
+++ b/sysdeps/unix/sysv/linux/mips/mips64/libm.abilist
@@ -1290,6 +1290,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libm.abilist b/sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libm.abilist
index c8ef606cf20..e14846a1322 100644
--- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libm.abilist
+++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libm.abilist
@@ -1102,6 +1102,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libm.abilist b/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libm.abilist
index b4ad3a696f5..98d677b4d68 100644
--- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libm.abilist
+++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libm.abilist
@@ -1101,6 +1101,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/be/libm.abilist b/sysdeps/unix/sysv/linux/powerpc/powerpc64/be/libm.abilist
index be0c29eadc9..50f82f92cc2 100644
--- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/be/libm.abilist
+++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/be/libm.abilist
@@ -1095,6 +1095,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/le/libm.abilist b/sysdeps/unix/sysv/linux/powerpc/powerpc64/le/libm.abilist
index 5669acaa564..f2aaa6c4c2e 100644
--- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/le/libm.abilist
+++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/le/libm.abilist
@@ -1479,6 +1479,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/s390/s390-32/libm.abilist b/sysdeps/unix/sysv/linux/s390/s390-32/libm.abilist
index 53679f9e012..5db036385c9 100644
--- a/sysdeps/unix/sysv/linux/s390/s390-32/libm.abilist
+++ b/sysdeps/unix/sysv/linux/s390/s390-32/libm.abilist
@@ -1393,6 +1393,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/s390/s390-64/libm.abilist b/sysdeps/unix/sysv/linux/s390/s390-64/libm.abilist
index 8cb45ad5268..da6f958dea0 100644
--- a/sysdeps/unix/sysv/linux/s390/s390-64/libm.abilist
+++ b/sysdeps/unix/sysv/linux/s390/s390-64/libm.abilist
@@ -1393,6 +1393,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/sh/be/libm.abilist b/sysdeps/unix/sysv/linux/sh/be/libm.abilist
index e8d4da9c49a..f3ae10872de 100644
--- a/sysdeps/unix/sysv/linux/sh/be/libm.abilist
+++ b/sysdeps/unix/sysv/linux/sh/be/libm.abilist
@@ -955,6 +955,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/sh/le/libm.abilist b/sysdeps/unix/sysv/linux/sh/le/libm.abilist
index e8d4da9c49a..f3ae10872de 100644
--- a/sysdeps/unix/sysv/linux/sh/le/libm.abilist
+++ b/sysdeps/unix/sysv/linux/sh/le/libm.abilist
@@ -955,6 +955,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/sparc/sparc32/libm.abilist b/sysdeps/unix/sysv/linux/sparc/sparc32/libm.abilist
index 86c0f3f7373..456b62f2cf8 100644
--- a/sysdeps/unix/sysv/linux/sparc/sparc32/libm.abilist
+++ b/sysdeps/unix/sysv/linux/sparc/sparc32/libm.abilist
@@ -1400,6 +1400,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/sparc/sparc64/libm.abilist b/sysdeps/unix/sysv/linux/sparc/sparc64/libm.abilist
index 1954e9f1ab4..ed32e0fe108 100644
--- a/sysdeps/unix/sysv/linux/sparc/sparc64/libm.abilist
+++ b/sysdeps/unix/sysv/linux/sparc/sparc64/libm.abilist
@@ -1290,6 +1290,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/x86_64/64/libm.abilist b/sysdeps/unix/sysv/linux/x86_64/64/libm.abilist
index abece7d9608..b36b1d96e2a 100644
--- a/sysdeps/unix/sysv/linux/x86_64/64/libm.abilist
+++ b/sysdeps/unix/sysv/linux/x86_64/64/libm.abilist
@@ -1323,6 +1323,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
diff --git a/sysdeps/unix/sysv/linux/x86_64/x32/libm.abilist b/sysdeps/unix/sysv/linux/x86_64/x32/libm.abilist
index 36b411f4e47..4474db45b94 100644
--- a/sysdeps/unix/sysv/linux/x86_64/x32/libm.abilist
+++ b/sysdeps/unix/sysv/linux/x86_64/x32/libm.abilist
@@ -1323,6 +1323,7 @@ GLIBC_2.43 acoshf F
GLIBC_2.43 asinf F
GLIBC_2.43 atan2f F
GLIBC_2.43 atanhf F
+GLIBC_2.43 coshf F
GLIBC_2.43 lgammaf F
GLIBC_2.43 lgammaf_r F
GLIBC_2.43 log10f F
--
2.43.0
More information about the Libc-alpha
mailing list