[PATCH v2 3/3] scripts: Support custom Git URLs in build-many-glibcs.py

[Yury Khrustalev]

Arjun, Carlos,

On Mon, Nov 24, 2025 at 12:19:31PM -0500, Carlos O'Donell wrote:
> On 11/19/25 7:54 AM, Yury Khrustalev wrote:
> > Use environment variables to provide mirror URLs to checkout
> > sources from Git. Each component has a corresponding env var
> > that will be used if it's present: <component>_GIT_MIRROR.
> 
> Arjun's comments stand.
> 
> Even with --replace-sources the URL is not updated, and so this change
> might in the worst case checkout code from a repo you didn't intend to
> reference.
> 
> Arjun provided a patch in the comment.

Thanks for the feedback and the suggestions.

The problem that I have here is testing. The script does not have any
dedicated tests to validate changes. On the other hand, the script is
overloaded with functionality. I didn't expect it to be a use case to
maintain an existing source folder, it seems too superfluous for this
script. I'd expect one checks out sources once and then uses them and
also maybe updates where a branch is checked out rather than a tag.

If there is a need to do a clean checkout of sources, then I would just
remove the folder and re-run the 'checkout' step again. Why do we need
--replace-sources? It's rhetorical, since we already have it, we have
to deal with the consequences of maintaining it, but I think it was a
mistake to add it.

Since the script has too much functionality for a simple helper tool,
it makes it hard to make any changes to it: it is likely to remain
untested and this will show up later when someone's workflow is broken.

I think it would be helpful to split CI part from the minimal build
part, but such major refactoring is for another time.

Thanks,
Yury