[PATCH] aarch64: Do not link conform tests with -Wl,-z,force-bti (bug 33601)

Florian Weimer fweimer@redhat.com
Thu Nov 6 19:54:55 GMT 2025


* Wilco Dijkstra:

> Hi Florian,
>
>> If the toolchain does not default to generate BTI markers in GCC,
>> the main program for conform runtime tests will not have the
>> BTI marker that -Wl,-z,force-bti requires.  Without -Wl,-z,force-bti,
>> the link editor will not tell the dynamic linker to enable BTI,
>> and the missing BTI marker is harmless.
>
> +ifneq ($(subdir),confirm)
>
> Eh, did you mean conform here?
>
> OK with that change.
>
> Reviewed-by: Wilco Dijkstra  <Wilco.Dijkstra@arm.com>

It's not correct either way. 8-/

This:

commit 2c421fc4302ecb729823ca442f9dfab95afba752
Author: Wilco Dijkstra <wilco.dijkstra@arm.com>
Date:   Wed May 14 16:32:31 2025 +0000

    AArch64: Cleanup PAC and BTI
    
    Now we finally support modern GCC and binutils, it's time for a cleanup.
    Use PAC and BTI instructions unconditionally and use proper assembler syntax.
    Remove the PR target/94791 strip_pac workarounds for buggy GCCs.  Remove the
    PAC/BTI configure checks - always emit GNU property notes on assembly files.
    Change cfi_window_save to the correct cfi_negate_ra_state unwind directive.
    
    Reviewed-by: Matthieu Longo <matthieu.longo@arm.com>

removed

LIBC_CONFIG_VAR([aarch64-bti], [$libc_cv_aarch64_bti])

so the sysdeps/aarch64/Makefile check is a no-op since then, and the bug
isn't in the current upstream sources, but it's still present in glibc
2.41 and earlier.

Should I apply the fixed patch there?

Thanks,
Florian



More information about the Libc-alpha mailing list