[PATCH 02/12] nss_compat: Use 'denylist' instead of 'blacklist' in code.

Carlos O'Donell carlos@redhat.com
Tue May 20 22:31:39 GMT 2025


On 5/20/25 8:02 AM, Florian Weimer wrote:
> * Carlos O'Donell:
> 
>> Use more inclusive language for structure and function names.
>> ---
>>   nss/nss_compat/compat-grp.c        | 90 ++++++++++++++--------------
>>   nss/nss_compat/compat-initgroups.c | 92 ++++++++++++++---------------
>>   nss/nss_compat/compat-pwd.c        | 92 ++++++++++++++---------------
>>   nss/nss_compat/compat-spwd.c       | 94 +++++++++++++++---------------
>>   4 files changed, 184 insertions(+), 184 deletions(-)
>>
>> diff --git a/nss/nss_compat/compat-grp.c b/nss/nss_compat/compat-grp.c
>> index 86a46d0622..e6312183ab 100644
>> --- a/nss/nss_compat/compat-grp.c
>> +++ b/nss/nss_compat/compat-grp.c
>> @@ -48,9 +48,9 @@ static enum nss_status (*endgrent_impl) (void);
>>   #include <nss/nss_files/files-parse.c>
>>   
>>   /* Structure for remembering -group members ... */
>> -#define BLACKLIST_INITIAL_SIZE 512
>> -#define BLACKLIST_INCREMENT 256
>> -struct blacklist_t
>> +#define DENYLIST_INITIAL_SIZE 512
>> +#define DENYLIST_INCREMENT 256
>> +struct denylist_t
>>   {
>>     char *data;
>>     int current;
>> @@ -62,7 +62,7 @@ struct ent_t
>>     bool files;
>>     enum nss_status setent_status;
>>     FILE *stream;
>> -  struct blacklist_t blacklist;
>> +  struct denylist_t denylist;
>>   };
>>   typedef struct ent_t ent_t;
> 
> It's not denying access (not entirely far-fetched given that this for
> the /etc/group database), so I would suggest something like
> exclusion_list_t.

That works. I'll split this and post a v2.

-- 
Cheers,
Carlos.



More information about the Libc-alpha mailing list