[PATCH 1/2] support: Use const char * argument in support_capture_subprogram_self_sgid
Florian Weimer
fweimer@redhat.com
Tue May 20 15:55:52 GMT 2025
The function does not modify the passed-in string, so make this clear
via the prototype.
---
support/capture_subprocess.h | 3 +--
support/support_capture_subprocess.c | 6 +++---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/support/capture_subprocess.h b/support/capture_subprocess.h
index 91d75e5d6b..77140430d2 100644
--- a/support/capture_subprocess.h
+++ b/support/capture_subprocess.h
@@ -45,8 +45,7 @@ struct support_capture_subprocess support_capture_subprogram
/* Copy the running program into a setgid binary and run it with CHILD_ID
argument. If execution is successful, return the exit status of the child
program, otherwise return a non-zero failure exit code. */
-int support_capture_subprogram_self_sgid
- (char *child_id);
+int support_capture_subprogram_self_sgid (const char *child_id);
/* Deallocate the subprocess data captured by
support_capture_subprocess. */
diff --git a/support/support_capture_subprocess.c b/support/support_capture_subprocess.c
index c3ef478d17..d99aafd370 100644
--- a/support/support_capture_subprocess.c
+++ b/support/support_capture_subprocess.c
@@ -110,7 +110,7 @@ support_capture_subprogram (const char *file, char *const argv[],
safely make it SGID with the TARGET group ID. Then runs the
executable. */
static int
-copy_and_spawn_sgid (char *child_id, gid_t gid)
+copy_and_spawn_sgid (const char *child_id, gid_t gid)
{
char *dirname = xasprintf ("%s/tst-tunables-setuid.%jd",
test_dir, (intmax_t) getpid ());
@@ -182,7 +182,7 @@ copy_and_spawn_sgid (char *child_id, gid_t gid)
ret = 0;
infd = outfd = -1;
- char * const args[] = {execname, child_id, NULL};
+ char * const args[] = {execname, (char *) child_id, NULL};
status = support_subprogram_wait (args[0], args);
@@ -211,7 +211,7 @@ err:
}
int
-support_capture_subprogram_self_sgid (char *child_id)
+support_capture_subprogram_self_sgid (const char *child_id)
{
gid_t target = 0;
const int count = 64;
base-commit: 2071666d0387c3723db3141ee026e963ac840a4e
--
2.49.0
More information about the Libc-alpha
mailing list