[PATCH v2] Enable -mrop-protect through configure command

Peter Bergner peter@bergner.org
Tue May 13 22:49:30 GMT 2025


On 5/12/25 1:04 AM, Sachin Monga wrote:
> @Peter Bergner <mailto:peter@bergner.org> and others
>>-ASFLAGS := $(filter -g% -fdebug-prefix-map=%,$(CFLAGS))
>>+ASFLAGS := $(filter -g% -fdebug-prefix-map=% -m%,$(CFLAGS))
> 
> How about filtering the complete switch -mrop-protect here  like the below?
> That will also ensure that we end up overriding -Werror=undef

I'm not sure I understand what you're saying in that last sentence.

That said, I don't think adding a machine specific option to the architecture
neutral Makeconfig is a good idea.  That why I mentioned maybe just allowing
all targets' machine specific options to be passed to ASFLAGS via the -m%
usage, since many of those options could set predefined macros that some
machine specific asm files may want to test to enable/disable some code.

I'm not sure there is any harm in that, but maybe there is on some targets???

Peter




More information about the Libc-alpha mailing list