[PATCH RFC v3 6/8] hurd/termios: remove USE_OLD_TTY

H. Peter Anvin hpa@zytor.com
Mon May 12 18:12:19 GMT 2025


On 5/8/25 11:35, Adhemerval Zanella Netto wrote:
 >
>> -#endif /* USE_OLD_TTY */
> 
>> -#endif
> 
> I think this removal went to far, it broke hurd build:
> 
> In file included from ../misc/sys/ioctl.h:26,
>                   from ../include/sys/ioctl.h:2,
>                   from [..]i686-gnu/sysroot/include/hurd/ioctl_types.h:26,
>                   from [..]build/i686-gnu/hurd/RPC_tioctl_tiocmodg.c:53:
> ../sysdeps/mach/hurd/bits/ioctls.h:18: error: unterminated #ifndef
>     18 | #ifndef __BITS_IOCTLS_H
> 
> Besides it, this change looks ok although I will let Hurd guys to do
> the proper review.
> 

Oops, hah!

Yeah that final #endif delete was definitely a mistake.

	-hpa



More information about the Libc-alpha mailing list