[PATCH v3 2/2] x86: Use separate variable for TLSDESC XSAVE/XSAVEC state size (bug 32810)

[Sunil Pandey]

On Fri, Mar 28, 2025 at 12:16 PM Florian Weimer <fweimer@redhat.com> wrote:

> * Sunil Pandey:
>
> > For me, simple test still fail...
> >
> > Program received signal SIGSEGV, Segmentation fault.
> > 0x00007ffff7fd5f2b in _dl_fixup (l=0x0, reloc_arg=0) at dl-runtime.c:48
> > warning: Source file is more recent than executable.
> > 48    = (const void *) D_PTR (l, l_info[DT_SYMTAB]);
>
> It says “warning: Source file is more recent than executable.”.  Are you
> actually testing the right binaries?
>

My bad, it works. In addition my testing on APX and non-APX systems
completed successfully.
Looks good to me.

I'm looking further to see if this logic can be simplified.


>
> >  Do we have to fix this line from
> >
> > sysdeps/x86_64/dl-trampoline.h:59         sub _
> >
> rtld_local_ro+RTLD_GLOBAL_RO_DL_X86_CPU_FEATURES_OFFSET+XSAVE_STATE_SIZE_OFFSET(%rip),
> > %RSP_LP
> >
> > to
> >
> > sysdeps/x86_64/dl-trampoline.h:59
>  _dl_x86_features_tlsdesc_state_size(%rip), %RSP_LP
>
> I don't think so, we want the smaller stack size for lazy binding.
>
> Thanks,
> Florian
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://sourceware.org/pipermail/libc-alpha/attachments/20250328/76edff26/attachment.htm>