[PATCH v3 09/10] stdio-common: Reject significand prefixes in scanf [BZ #12701]

Maciej W. Rozycki macro@redhat.com
Fri Mar 28 12:47:29 GMT 2025


On Tue, 25 Mar 2025, Joseph Myers wrote:

> This patch is OK, but I don't think it (plus patch 10) completely fixes 
> all hex float cases of bug 12701; I think another followup patch will be 
> needed to complete the fix.  Specifically, "0x." or "0X.", optionally 
> preceded by a sign, is another case that's a prefix of a matching sequence 
> but not a valid matching sequence itself (and I don't see any inputs 
> starting with "0x." or "0X." in the recently added tests).

 Correct, I identified these additional cases in the course of making the 
fixes just as I was about to send v2.  I chose not to delay the patchset 
for this reason, but I have a fix in the works.  I'll probably just update 
the inputs added in the course of this effort with suitable data rather 
than making entirely new tests for these problematic inputs.

 Thank you for your review.  I have applied this and the remaining patches 
now.

  Maciej



More information about the Libc-alpha mailing list