[PATCH] Linux: Inhibit tail calls in cancellable system calls
Carlos O'Donell
carlos@redhat.com
Mon Mar 24 13:37:44 GMT 2025
On 3/21/25 9:01 AM, Florian Weimer wrote:
> Without this change, the system call wrapper function is not visible
> on the stack at the time of the system call, which causes problems
> for interception tools such as valgrind.
>
> Enhances commit 89b53077d2a58f00e7debdfe58afabe953dac60d ("nptl: Fix
> Race conditions in pthread cancellation [BZ#12683]").
>
> Tested on i686-linux-gnu, powerpc64le-linux-gnu, x86_64-linux-gnu.
> (We're still discussing if valgrind needs this, but if it does, here's a
> patch.)
We discussed this on the weekly patch queue review.
Glad to see the Valgrind discussion is ongoing.
This has cross-architecture implications, and can add extra function calls.
I'm marking the patch in patchwork as changes requested since we should review
and discuss Adhemerval's suggestion.
--
Cheers,
Carlos.
More information about the Libc-alpha
mailing list