[RFC 1/5] elf: Add SFrame support to _dl_find_object function

Joseph Myers josmyers@redhat.com
Tue Mar 18 16:25:35 GMT 2025


On Tue, 18 Mar 2025, claudiu.zissulescu-ianculescu@oracle.com wrote:

> diff --git a/dlfcn/dlfcn.h b/dlfcn/dlfcn.h
> index 5747962611..dd4113a757 100644
> --- a/dlfcn/dlfcn.h
> +++ b/dlfcn/dlfcn.h
> @@ -216,6 +216,9 @@ struct dl_find_object
>  # if DLFO_STRUCT_HAS_EH_COUNT
>    int dlfo_eh_count;		/* Number of exception handling entries.  */
>    unsigned int __dlfo_eh_count_pad;
> +# endif
> +# if DLFO_STRUCT_HAS_SFRAME
> +  void *dlfo_sframe;		/* SFrame stack trace data of the object.  */
>  # endif
>    __extension__ unsigned long long int __dflo_reserved[7];
>  };

Don't you need to update __dflo_reserved (taking account of different 
pointer sizes depending on the architecture) to avoid ABI issues?  In 
general, please provide details of the ABI impact of this patch series and 
how you avoid any compatibility issues with existing binaries using this 
structure.

-- 
Joseph S. Myers
josmyers@redhat.com



More information about the Libc-alpha mailing list