[PATCH] tst-fopen-threaded: Only check EOF for failing read

Siddhesh Poyarekar siddhesh@sourceware.org
Fri Mar 14 15:30:48 GMT 2025


On 2025-03-14 11:05, Siddhesh Poyarekar wrote:
> On 2025-03-14 10:55, Florian Weimer wrote:
>> * Siddhesh Poyarekar:
>>
>>> -  ret =
>>> -    fread (&read_buffer, sizeof (char), sizeof (read_buffer), 
>>> my_data->fd);
>>> -  if (feof (my_data->fd) != 0)
>>> +  ret = fread (&read_buffer, sizeof (char), sizeof (read_buffer), 
>>> my_data->fd);

Verified on a 96 core x86_64 machine that the test no longer fails. 
Without this patch the following would fail within seconds:

    while ./testrun.sh nptl/tst-fopen-threaded; do true; done

Thanks,
Sid


More information about the Libc-alpha mailing list