[PATCH COMMITTED] configure: Fix spelling of -Wl,--no-error-execstack option

[Sam James]

Florian Weimer <fweimer@redhat.com> writes:

> BFD ld recognizes all -no-* options (with a single leading dash)
> unconditionally.
>
> Fixes commit a2bd5008a99032830add3e4005c25b61e3207112
> ("Pass -Wl,--no-error-execstack for tests where -Wl,-z,execstack
> is used [PR32717]").

Thanks. The "helpful" disambiguation it does is why I didn't notice.

>
> ---
>  configure    | 4 ++--
>  configure.ac | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index 2a996cb0d9..674d1d7e4a 100755
> --- a/configure
> +++ b/configure
> @@ -7122,7 +7122,7 @@ cat > conftest.c <<EOF
>  int _start (void) { return 42; }
>  EOF
>  if { ac_try='${CC-cc} $CFLAGS $CPPFLAGS $LDFLAGS $no_ssp
> -		  -Wl,-no-error-execstack -nostdlib -nostartfiles
> +		  -Wl,--no-error-execstack -nostdlib -nostartfiles
>  		  -fPIC -shared -o conftest.so conftest.c
>  		  1>&5'
>    { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5
> @@ -7131,7 +7131,7 @@ if { ac_try='${CC-cc} $CFLAGS $CPPFLAGS $LDFLAGS $no_ssp
>    printf "%s\n" "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5
>    test $ac_status = 0; }; }
>  then
> -  if ${CC-cc} $CFLAGS $CPPFLAGS $LDFLAGS $no_ssp -Wl,-no-error-execstack -nostdlib \
> +  if ${CC-cc} $CFLAGS $CPPFLAGS $LDFLAGS $no_ssp -Wl,--no-error-execstack -nostdlib \
>        -nostartfiles -fPIC -shared -o conftest.so conftest.c 2>&1 \
>        | grep "warning: --no-error-execstack ignored" > /dev/null 2>&1; then
>      true
> diff --git a/configure.ac b/configure.ac
> index 5f6f0b72bc..57cd24c87d 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1318,7 +1318,7 @@ if test $libc_cv_as_noexecstack = yes; then
>  fi
>  AC_SUBST(ASFLAGS_config)
>  
> -LIBC_LINKER_FEATURE([--no-error-execstack], [-Wl,-no-error-execstack],
> +LIBC_LINKER_FEATURE([--no-error-execstack], [-Wl,--no-error-execstack],
>  		    [libc_cv_no_error_execstack=yes], [libc_cv_no_error_execstack=no])
>  AC_SUBST(libc_cv_no_error_execstack)
>  
>
> base-commit: 5b309075456e07b6231db331092a1f307cb7664b