[PATCH] glibc/manual/examples: add missing free to open_memstream example

Ravina Jain rajulravina123@gmail.com
Tue Jun 24 14:30:56 GMT 2025


Yes, Arjun. I will make the changes and share it again shortly.












Thanks!
Ravina R. Jain















On Tue, Jun 24, 2025 at 7:46 PM Arjun Shankar <arjun@redhat.com> wrote:

> > > We should fix it because:
> > > a) nobody will file a bug for the unnecessary free in an example, but
> someone will surely
> > > file a bug or send a patch again to add the free;
>
> And in fact, there is actually already a bug filed for this:
> https://sourceware.org/bugzilla/show_bug.cgi?id=27866
>
> Ravina's patch is coming out of an in-person workshop I ran a few days
> ago in Brno to try and get first-time contributors into glibc.
>
> > > b) examples are supposed to be exemplar and form part of larger
> > > programs.
> >
> > I agree with Sam.
> >
> > Ravina, would you resend please with the formatting issue fixed?
>
> Ravina, while you do a v2, would you also please make a minor change
> to the commit subject?: 1. Drop the "glibc/" from the commit subject
> line, and 2. Add the bug reference. So:
>
> "manual: Add missing free to open_memstream example [BZ #27866]"
>
> Thanks!
>
> --
> Arjun Shankar
> he/him/his
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://sourceware.org/pipermail/libc-alpha/attachments/20250624/c10ec8a4/attachment-0001.htm>


More information about the Libc-alpha mailing list