[PATCH v7 2/8] posix: let the getopt caller set the translation context

[Adhemerval Zanella Netto]

On 23/06/25 16:27, Florian Weimer wrote:
> * Adhemerval Zanella Netto:
> 
>> On 23/06/25 15:21, Vivien Kraus wrote:
>>> Hello!
>>>
>>> Le lundi 23 juin 2025 à 12:36 -0300, Adhemerval Zanella Netto a écrit :
>>>> You need to update all the afected libc.abilist.  On aarch64:
>>>>
>>>> --- ../sysdeps/unix/sysv/linux/aarch64/libc.abilist	2025-06-23
>>>> 12:01:07.258632245 -0300
>>>> +++ /[...]/libc.symlist	2025-06-23 12:09:09.305479003 -0300
>>>> @@ -2764,0 +2765 @@ GLIBC_2.42 cfsetspeed F
>>>> +GLIBC_2.42 optctxt D 0x8
>>>>   0x0308: Rev: 1  Flags: none  Index: 23  Cnt: 2  Name:
>>>> GLIBC_ABI_DT_RELR
>>>
>>> How did you find that? Is there a reason to expect more architectures
>>> with a missing definition, or is aarch64 the only one? I tried to run
>>> make update-all-abi but it does not do anything.
>>
>> The patchwork CI caught the issue [1], but it does not check all supported
>> ABIs. For patches that add new symbols, I usually build and run update-abi
>> and/or check-abi for all ABIs that have a libc.abilist file.
>>
>> The make update-abi targets only the build target (--target), on current
>> build scheme a update-all-abi is not really possible.
> 
> For symbol additions like these, “make update-all-abi” should actually
> work.  But there has to be an ABI check failure to patch up.  If you
> already fixed the current build, then there is no ABI failure to patch
> across all architectures.

I have not dig into details, but update-all-abi fails to update aarch64 
abilist (running from a x86_64-linux-gnu build).

Running from aarch64 build o x86_64 does update a lot of abifiles:

        modified:   sysdeps/mach/hurd/i386/libc.abilist
        modified:   sysdeps/unix/sysv/linux/aarch64/libc.abilist
        modified:   sysdeps/unix/sysv/linux/alpha/libc.abilist
        modified:   sysdeps/unix/sysv/linux/arc/libc.abilist
        modified:   sysdeps/unix/sysv/linux/arm/be/libc.abilist
        modified:   sysdeps/unix/sysv/linux/arm/le/libc.abilist
        modified:   sysdeps/unix/sysv/linux/csky/libc.abilist
        modified:   sysdeps/unix/sysv/linux/hppa/libc.abilist
        modified:   sysdeps/unix/sysv/linux/i386/libc.abilist
        modified:   sysdeps/unix/sysv/linux/m68k/coldfire/libc.abilist
        modified:   sysdeps/unix/sysv/linux/m68k/m680x0/libc.abilist
        modified:   sysdeps/unix/sysv/linux/microblaze/be/libc.abilist
        modified:   sysdeps/unix/sysv/linux/microblaze/le/libc.abilist
        modified:   sysdeps/unix/sysv/linux/mips/mips32/fpu/libc.abilist
        modified:   sysdeps/unix/sysv/linux/mips/mips32/nofpu/libc.abilist
        modified:   sysdeps/unix/sysv/linux/mips/mips64/n32/libc.abilist
        modified:   sysdeps/unix/sysv/linux/mips/mips64/n64/libc.abilist
        modified:   sysdeps/unix/sysv/linux/or1k/libc.abilist
        modified:   sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libc.abilist
        modified:   sysdeps/unix/sysv/linux/powerpc/powerpc32/nofpu/libc.abilist
        modified:   sysdeps/unix/sysv/linux/powerpc/powerpc64/be/libc.abilist
        modified:   sysdeps/unix/sysv/linux/powerpc/powerpc64/le/libc.abilist
        modified:   sysdeps/unix/sysv/linux/riscv/rv32/libc.abilist
        modified:   sysdeps/unix/sysv/linux/s390/s390-32/libc.abilist
        modified:   sysdeps/unix/sysv/linux/sh/be/libc.abilist
        modified:   sysdeps/unix/sysv/linux/sh/le/libc.abilist
        modified:   sysdeps/unix/sysv/linux/sparc/sparc32/libc.abilist
        modified:   sysdeps/unix/sysv/linux/x86_64/x32/libc.abilist

Maybe the scripts/update-abilist.sh is not taking in consideration all
abis when some abi is already updated?