[PATCH] Fix termios related targets

Adhemerval Zanella Netto adhemerval.zanella@linaro.org
Wed Jun 18 14:06:09 GMT 2025



On 18/06/25 11:00, Andreas Schwab wrote:
> Move Linux-specific termios headers and tests from misc to termios subdir
> and install newly added bits/termios-cbaud.h.

LGTM thanks (that is the same of I was intend to send).

Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>

> ---
>  sysdeps/unix/sysv/linux/Makefile | 27 ++++++++++++++++++---------
>  1 file changed, 18 insertions(+), 9 deletions(-)
> 
> diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile
> index 913fe736bc..c6b2db8377 100644
> --- a/sysdeps/unix/sysv/linux/Makefile
> +++ b/sysdeps/unix/sysv/linux/Makefile
> @@ -151,14 +151,6 @@ sysdep_headers += \
>    bits/struct_stat.h \
>    bits/struct_stat_time64_helper.h \
>    bits/syscall.h \
> -  bits/termios-c_cc.h \
> -  bits/termios-c_cflag.h \
> -  bits/termios-c_iflag.h \
> -  bits/termios-c_lflag.h \
> -  bits/termios-c_oflag.h \
> -  bits/termios-misc.h \
> -  bits/termios-struct.h \
> -  bits/termios-tcflow.h \
>    bits/timerfd.h \
>    bits/types/struct_msqid64_ds.h \
>    bits/types/struct_msqid64_ds_helper.h \
> @@ -236,7 +228,6 @@ tests += \
>    tst-sysvmsg-linux \
>    tst-sysvsem-linux \
>    tst-sysvshm-linux \
> -  tst-termios-linux \
>    tst-tgkill \
>    tst-timerfd \
>    tst-ttyname-direct \
> @@ -421,6 +412,24 @@ tst-rseq-disable-static-ENV = GLIBC_TUNABLES=glibc.pthread.rseq=0
>  
>  endif # $(subdir) == misc
>  
> +ifeq ($(subdir),termios)
> +sysdep_headers += \
> +  bits/termios-c_cc.h \
> +  bits/termios-c_cflag.h \
> +  bits/termios-c_iflag.h \
> +  bits/termios-c_lflag.h \
> +  bits/termios-c_oflag.h \
> +  bits/termios-cbaud.h \
> +  bits/termios-misc.h \
> +  bits/termios-struct.h \
> +  bits/termios-tcflow.h \
> +  # sysdep_headers
> +
> +tests += \
> +  tst-termios-linux \
> +  # tests
> +endif
> +
>  ifeq ($(subdir),time)
>  sysdep_headers += \
>    bits/timex.h \



More information about the Libc-alpha mailing list