[PATCH 1/2] route/Makefile: Split tests lines

[Arjun Shankar]

Hi Petr,

Thanks for the patch!

My comments are inline:

> Signed-off-by: Petr Menšík <pemensik@redhat.com>
> ---
>  resolv/Makefile | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/resolv/Makefile b/resolv/Makefile
> index 8fa3398d76..f38c892d54 100644
> --- a/resolv/Makefile
> +++ b/resolv/Makefile
> @@ -79,7 +79,12 @@ routines_no_fortify += \
>    inet_pton \
>    # routines_no_fortify
>
> -tests = tst-aton tst-leaks tst-inet_ntop
> +tests = \
> +  tst-aton \
> +  tst-leaks \
> +  tst-inet_ntop \
> +# base tests

This should be "# tests" instead of "# base tests". The linter looks
for a "tests =" start and "# tests" end pair to recognize a sorted
list. Otherwise the entire section is ignored for linting purposes.
Also, we usually go with the same double-space indent to mark the end,
like this:
"  # tests".

After setting up the start and end markers correctly, you may run:

$ bash scripts/lint-makefiles.sh python3 . > fix-makefiles.patch

Then apply it in reverse, IIRC:
patch -p1 -R < fix-makefiles.patch

And it will correctly sort the list.

Thanks!

-- 
Arjun Shankar
he/him/his