[PATCH] iconv: fixing error wording [BZ #31641]
Collin Funk
collin.funk1@gmail.com
Sat Jun 14 17:18:10 GMT 2025
Hi Augustin,
Augustin Osusky <augustin.osusky@gmail.com> writes:
> Hello,
> this is just a small patch referencing
> https://sourceware.org/bugzilla/show_bug.cgi?id=31641
> I am mostly learning the patch process for this project.
Thank you for contributing.
> From e395c660f14f3b8b4038d00f2733bd5e3d930ebb Mon Sep 17 00:00:00 2001
> From: Augustin Osusky <augustin.osusky@gmail.com>
> Date: Sat, 14 Jun 2025 11:30:40 +0200
> Subject: [PATCH] iconv: fixing error wording [BZ #31641]
>
> This is just a string update. Test suite was executed to verify it.
> Author: Augustin.Osusky@gmail.com
> ---
> iconv/iconv_charmap.c | 2 +-
> iconv/iconv_prog.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
The "Author:" tag is not needed since git already stores this
information. When a maintainer downloads the patch and does 'git am', it
uses the "From:" field and sets the author to your name and email.
Instead you should read the DCO listed on the glibc wiki [1]. If you
read it and decide that you are still able to contribute, you can add
the "Signed-off-by:" tag to your commit.
Collin
[1] https://sourceware.org/glibc/wiki/Contribution%20checklist#Developer_Certificate_of_Origin
More information about the Libc-alpha
mailing list