[PATCH v11 2/2] malloc: add testing for large tcache support.

[Wilco Dijkstra]

Hi Cupertino,

This looks good, only 2 minor issues which should be fixed before commit (see below).

Reviewed-by: Wilco Dijkstra  <Wilco.Dijkstra@arm.com>

+# All malloc-largetcache tests will be run with GLIBC_TUNABLE=glibc.malloc.tcache_max=1048576:glibc.mallc.tcache_max_large_capacity=4194304
+define malloc-largetcache-ENVS
+$(1)-malloc-largetcache-ENV += GLIBC_TUNABLES=glibc.malloc.tcache_max=1048576:glibc.mallc.tcache_max_large_capacity=4194303

The glibc.mallc.tcache_max_large_capacity seems a leftover from an earlier
revision? Note also it would have no effect due to "mallc"...

--- a/malloc/Makefile
+++ b/malloc/Makefile
@@ -147,6 +147,21 @@ tests-malloc-hugetlb1 = \
 tests-malloc-hugetlb2 = \
         $(filter-out $(tests-exclude-hugetlb2), $(tests))
 
+tests-exclude-largetcache = \
+  tst-compathooks-off \
+  tst-compathooks-on \
+  tst-interpose-thread \
+  tst-interpose-nothread \
+  tst-interpose-static-nothread \
+  tst-interpose-static-thread \
+  tst-mallocstate \
+  tst-malloc-backtrace \
+  tst-malloc-usable \
+  tst-malloc-usable-tunables

The last entry should still have a '\' and immediately after it:

# tests-exclude-largetcache

The order of the names should be like # tests-exclude-hugetlb1 above it so it won't
give lint-makefile errors.

Cheers,
Wilco