[PATCH 4/7] math: Simplify and optimize modf implementation

Wilco Dijkstra Wilco.Dijkstra@arm.com
Wed Jun 11 14:27:46 GMT 2025


Hi Adhemerval,

A few comments similar to modff:

+static inline int
+get_exponent (uint64_t x)
+{
+  return (int)(x >> MANTISSA_WIDTH & 0x7ff) - EXPONENT_BIAS;

Better to add parenthesis.

+	  /* |x|<1 -> *iptr = +-0 */
+	  *iptr = asdouble (t & SIGN_MASK);;

Extra ';'

+      uint64_t i = UINT64_C(0x000fffffffffffff) >> e;

MANTISSA_MASK

+  /* Set invalid operation for sNaN.  */
+  *iptr = x * 1.0;
+  if ((e == 0x400) && (t & UINT64_C(0xfffffffffffff)))

MANTISSA_MASK

Cheers,
Wilco


More information about the Libc-alpha mailing list