[PATCH v1] powerpc64le: Revert "Optimized strcmp for power10"
Carlos O'Donell
carlos@redhat.com
Wed Jun 11 13:16:34 GMT 2025
On 6/10/25 10:22 AM, Siddhesh Poyarekar wrote:
> On 2025-06-06 13:45, Sachin Monga wrote:
>> This reverts commit 3367d8e180848030d1646f088759f02b8dfe0d6f.
>>
>> Reason for revert: Power 10 strcmp clobbers nonvolatile
>> vector registers (bug 33056).
>>
>> Signed-off-by: Sachin Monga <smonga@linux.ibm.com>
>
> Thanks, please also backport this to 2.40 and 2.39.
>
> Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
This is incomplete, and I'd like to see this done in reverse order
that they were applied to the branch since it makes it easier to
audit and work it out. A series with all 3 reverted, or the strncmp
revert first, then the memchr, then the strcmp. Then we can work them
forwards in any order.
Suggested order:
Revert strncmp 23f0d81608d0ca6379894ef81670cf30af7fd081 (May 2024)
Revert memchr b9182c793caa05df5d697427c0538936e6396d4b (Dec 2023)
Revert strcmp 3367d8e180848030d1646f088759f02b8dfe0d6f (Dec 2024)
--
Cheers,
Carlos.
More information about the Libc-alpha
mailing list