[PATCH v8] locale: memory leak in newlocale [BZ #25770]

Florian Weimer fweimer@redhat.com
Wed Jun 4 17:42:11 GMT 2025


* Dmitry Kovalenko:

> +
> +    if (r != 0)
> +      FAIL_EXIT1 ("setenv: %m");
> +
> +    if (l == NULL)
> +      FAIL_EXIT1 ("newlocale failed: %m");
>
> I think, it is better to use the one format for these messages - "xxxx failed: %m".

You could use TEST_COMPARE and TEST_VERIFY instead, then you won't even
have to write a message. 8-)

Thanks,
Florian



More information about the Libc-alpha mailing list