[PATCH] configure.ac: fix bashisms in SFrame checks
Adhemerval Zanella Netto
adhemerval.zanella@linaro.org
Mon Jul 28 13:15:25 GMT 2025
We still require bash in a lot of places, but patch looks to me.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
On 28/07/25 10:00, Sam James wrote:
> ---
> configure | 4 ++--
> configure.ac | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/configure b/configure
> index e8de94464c..180e49d95b 100755
> --- a/configure
> +++ b/configure
> @@ -9439,7 +9439,7 @@ if test $ac_verc_fail = yes; then
> libc_cv_sframe_readelf_version=no
> fi
>
> - if test $libc_cv_sframe_readelf_version == no; then
> + if test $libc_cv_sframe_readelf_version = no; then
> { { printf "%s\n" "$as_me:${as_lineno-$LINENO}: error: in '$ac_pwd':" >&5
> printf "%s\n" "$as_me: error: in '$ac_pwd':" >&2;}
> as_fn_error $? "binutils too old to enable SFrame
> @@ -9472,7 +9472,7 @@ fi
> { printf "%s\n" "$as_me:${as_lineno-$LINENO}: result: $libc_cv_default_sframe" >&5
> printf "%s\n" "$libc_cv_default_sframe" >&6; }
>
> - if test $libc_cv_default_sframe == no; then
> + if test $libc_cv_default_sframe = no; then
> { { printf "%s\n" "$as_me:${as_lineno-$LINENO}: error: in '$ac_pwd':" >&5
> printf "%s\n" "$as_me: error: in '$ac_pwd':" >&2;}
> as_fn_error $? "toolchain doesn't support SFrame v2 or higher
> diff --git a/configure.ac b/configure.ac
> index fc01d054ba..4480ae83bb 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -2134,7 +2134,7 @@ if test $use_sframe = yes; then
> [GNU readelf.* \([0-9][0-9]*\.[0-9.]*\)],
> [2.4[5-9]*|2.[5-9][0-9]*|2.[1-9][0-9][0-9]*|[3-9]*|[1-9][0-9]*],
> libc_cv_sframe_readelf_version=no)
> - if test $libc_cv_sframe_readelf_version == no; then
> + if test $libc_cv_sframe_readelf_version = no; then
> AC_MSG_FAILURE([binutils too old to enable SFrame])
> fi
>
> @@ -2156,7 +2156,7 @@ EOF
> rm -f conftest.c conftest.o
> ])
>
> - if test $libc_cv_default_sframe == no; then
> + if test $libc_cv_default_sframe = no; then
> AC_MSG_FAILURE([toolchain doesn't support SFrame v2 or higher])
> fi
>
>
> base-commit: 0def17238661b47fd8557aafaa1bb4805e6b28e8
> prerequisite-patch-id: bbbab5fb7fbbcd882ab3a5585712857a3e82e357
More information about the Libc-alpha
mailing list