[PATCH v2 1/4] Makeconfig: Add libgcc directory to rtld-prefix search path

[Andrew Pinski]

On Mon, Jul 21, 2025 at 8:27 AM Andreas Schwab <schwab@suse.de> wrote:
>
> On Jul 21 2025, Xi Ruoyao wrote:
>
> > On Mon, 2025-07-21 at 07:34 -0700, Andrew Pinski wrote:
> >> >    gnulib-extralibdir = $(shell $(CC) -print-file-name=libgcc_s.so$(libgcc_s.so-version) | sed 's#/[^/]*$$##')
> >>
> >> Though this looks like it is causing some issues with some shells. The
> >> `##` causes the reset of the line to be ignored and I get the
> >> following error message:
> >> ../Makeconfig:721: *** unterminated call to function 'shell': missing ')'. Stop.
> >
> > I'd say it's some versions of make instead of some shells, as it fails
> > even before getting into the shell.
>
> From the NEWS of GNU make 4.3:

So make 4.3 is fixed but glibc officially only requires 4.0+. Do we
change the requirement or workaround older makes?

Thanks,
Andrew


>
> * WARNING: Backward-incompatibility!
>   Number signs (#) appearing inside a macro reference or function invocation
>   no longer introduce comments and should not be escaped with backslashes:
>   thus a call such as:
>     foo := $(shell echo '#')
>   is legal.  Previously the number sign needed to be escaped, for example:
>     foo := $(shell echo '\#')
>   Now this latter will resolve to "\#".  If you want to write makefiles
>   portable to both versions, assign the number sign to a variable:
>     H := \#
>     foo := $(shell echo '$H')
>   This was claimed to be fixed in 3.81, but wasn't, for some reason.
>   To detect this change search for 'nocomment' in the .FEATURES variable.
>
> --
> Andreas Schwab, SUSE Labs, schwab@suse.de
> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
> "And now for something completely different."