[PATCH v2 1/2] configure: Disable SFrame backtracing

[Sam James]

Claudiu Zissulescu-Ianculescu <claudiu.zissulescu-ianculescu@oracle.com> writes:

>>> -if test $use_sframe$libc_cv_default_sframe = yesyes || \
>>> -   test $use_sframe$libc_cv_default_sframe = notsetyes; then
>>> -  enable_gsframe=yes
>>> -elif test $use_sframe = yes; then
>>> -   AC_MSG_FAILURE([toolchain doesn't support SFrame v2 or higher])
>> 
>> I commented on this before but wasn't so bothered by it, but kind of
>> changed my mind now: don't we want to error out with explicit
>> --enable-sframe if our Binutils is too old?
>> 
> If it is too old, the SFrame will not be enabled anyhow, as either is
> not supported or its output is not suitable.
>
> However, I can reintroduce the error message if required.

The convention is that if you express nothing (i.e. rely on some
default), you're usually okay with "guessing the right thing", whereas
if you explicitly pass --enable-XXX and it cannot be honoured, it should
error out rather than silently (or semi-silently with just an autoconf
warning) doing something you didn't want.

Let's put the error back in if that's OK.

>
> //Claudiu