[PATCH v7 1/6] elf: Add SFrame support to _dl_find_object function

Claudiu Zissulescu-Ianculescu claudiu.zissulescu-ianculescu@oracle.com
Fri Jul 11 09:58:46 GMT 2025


Hi,

>> @@ -84,6 +147,7 @@ _dl_find_object_to_external (struct dl_find_object_internal *internal,
>>  # if DLFO_STRUCT_HAS_EH_COUNT
>>    external->dlfo_eh_count = internal->eh_count;
>>  # endif
>> +  external->dlfo_sframe = internal->sframe;
>>  }
> 
> You can just do
> 
>   if (internal->sframe != NULL)
>     external->dlfo_flags = DLF_SFRAME;
>   else
>     external->dlfo_flags = 0;
> 
> I think.  No need to keep track of the flags field in the internal data
> structure.
> 
Thank you, this is simplifying the code.  I was not very sure how to
handle efficiently the setting of the dlfo_flags from the beginning.

Claudiu


More information about the Libc-alpha mailing list