[PATCH 2/3] termios: Move isatty, __isatty_nostatus from io
Adhemerval Zanella Netto
adhemerval.zanella@linaro.org
Thu Jul 10 17:56:33 GMT 2025
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
On 10/07/25 12:18, Florian Weimer wrote:
> The definition may depend on termios internals.
> ---
> io/Makefile | 2 --
> io/Versions | 3 ---
> termios/Makefile | 2 ++
> termios/Versions | 3 +++
> {io => termios}/isatty.c | 0
> {io => termios}/isatty_nostatus.c | 0
> 6 files changed, 5 insertions(+), 5 deletions(-)
> rename {io => termios}/isatty.c (100%)
> rename {io => termios}/isatty_nostatus.c (100%)
>
> diff --git a/io/Makefile b/io/Makefile
> index edee38e233..435f5a994f 100644
> --- a/io/Makefile
> +++ b/io/Makefile
> @@ -91,8 +91,6 @@ routines := \
> getcwd \
> getdirname \
> getwd \
> - isatty \
> - isatty_nostatus \
> lchmod \
> lchown \
> link \
> diff --git a/io/Versions b/io/Versions
> index 4e19540885..04d196eee0 100644
> --- a/io/Versions
> +++ b/io/Versions
> @@ -26,9 +26,6 @@ libc {
> # g*
> get_current_dir_name; getcwd; getwd;
>
> - # i*
> - isatty;
> -
> # l*
> lchown; link; lockf; lseek;
>
> diff --git a/termios/Makefile b/termios/Makefile
> index 3cbd8917ad..1e23608255 100644
> --- a/termios/Makefile
> +++ b/termios/Makefile
> @@ -36,6 +36,8 @@ routines := \
> cfmakeraw \
> cfsetbaud \
> cfsetspeed \
> + isatty \
> + isatty_nostatus \
> speed \
> tcdrain \
> tcflow \
> diff --git a/termios/Versions b/termios/Versions
> index a5eec83257..03e2063b1f 100644
> --- a/termios/Versions
> +++ b/termios/Versions
> @@ -3,6 +3,9 @@ libc {
> # c*
> cfgetispeed; cfgetospeed; cfmakeraw; cfsetispeed; cfsetospeed; cfsetspeed;
>
> + # i*
> + isatty;
> +
> # t*
> tcdrain; tcflow; tcflush; tcgetattr; tcgetpgrp; tcsendbreak; tcsetattr;
> tcsetpgrp;
> diff --git a/io/isatty.c b/termios/isatty.c
> similarity index 100%
> rename from io/isatty.c
> rename to termios/isatty.c
> diff --git a/io/isatty_nostatus.c b/termios/isatty_nostatus.c
> similarity index 100%
> rename from io/isatty_nostatus.c
> rename to termios/isatty_nostatus.c
More information about the Libc-alpha
mailing list