[PATCH v7 14/23] aarch64: Mark objects with GCS property note

[Adhemerval Zanella Netto]

On 03/01/25 12:41, Yury Khrustalev wrote:
> From: Szabolcs Nagy <szabolcs.nagy@arm.com>
> 
> Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
> Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> ---
>  sysdeps/aarch64/sysdep.h | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/sysdeps/aarch64/sysdep.h b/sysdeps/aarch64/sysdep.h
> index 4df120ad80..036eb12527 100644
> --- a/sysdeps/aarch64/sysdep.h
> +++ b/sysdeps/aarch64/sysdep.h
> @@ -85,6 +85,7 @@ strip_pac (void *p)
>  #define FEATURE_1_AND 0xc0000000
>  #define FEATURE_1_BTI 1
>  #define FEATURE_1_PAC 2
> +#define FEATURE_1_GCS 4
>  
>  /* Add a NT_GNU_PROPERTY_TYPE_0 note.  */
>  #define GNU_PROPERTY(type, value)	\
> @@ -103,9 +104,9 @@ strip_pac (void *p)
>  /* Add GNU property note with the supported features to all asm code
>     where sysdep.h is included.  */
>  #if HAVE_AARCH64_BTI && HAVE_AARCH64_PAC_RET

Both HAVE_AARCH64_BTI and HAVE_AARCH64_PAC_RET have configure tests 
to check if -mbranch-protection={bti,pac-ret} is used.  Why do assume
GCS support for this case? Should it have a similar check for
-mbranch-protection=gcs?

> -GNU_PROPERTY (FEATURE_1_AND, FEATURE_1_BTI|FEATURE_1_PAC)
> +GNU_PROPERTY (FEATURE_1_AND, FEATURE_1_BTI|FEATURE_1_PAC|FEATURE_1_GCS)
>  #elif HAVE_AARCH64_BTI
> -GNU_PROPERTY (FEATURE_1_AND, FEATURE_1_BTI)
> +GNU_PROPERTY (FEATURE_1_AND, FEATURE_1_BTI|FEATURE_1_GCS)
>  #endif
>  
>  /* Define an entry point visible from C.  */