[PATCH 00/59] time: sync mktime from Gnulib

Joseph Myers josmyers@redhat.com
Mon Jan 6 21:34:40 GMT 2025


On Mon, 6 Jan 2025, Carlos O'Donell wrote:

> On 1/5/25 12:56 AM, Paul Eggert wrote:
> > This patch series syncs mktime from Gnulib.  Among the issues it fixes
> > is the problem reported by Florian a couple of days ago
> > in "mktime tm_isdst compatibility improvements"
> > <https://sourceware.org/pipermail/libc-alpha/2025-January/163342.html>.
> > This patch series fixes that problem differently from Florian's proposal,
> > without introducing a new glibc tunable.
> 
> Please do not push this while we are preparing for glibc 2.41 to go out
> on February 1st (I see you mention this in your other email, but I'll note
> the version and date here).
> 
> Please note that pre-commit CI has failed for this series and the patches
> introduce link namespace failures.
> 
> Link namespace failures can be seen here:
> https://patchwork.sourceware.org/project/glibc/patch/20250105055750.1668721-60-eggert@cs.ucla.edu/

Those look like conform (compile-time) namespace failures, not link 
namespace.  Concretely, in patch 5, the static_assert definition in the 
sys/cdefs.h wrapper needs to be under a !_ISOMAC conditional.

-- 
Joseph S. Myers
josmyers@redhat.com



More information about the Libc-alpha mailing list