[PATCH] Increase the amount of data tested in stdio-common/tst-fwrite-pipe.c
Stefan Liebler
stli@linux.ibm.com
Mon Feb 24 13:48:29 GMT 2025
On 2/24/25 14:14, Florian Weimer wrote:
> * Stefan Liebler:
>
>> The number of iterations and the length of the string are not high
>> enough on some systems causing the test to return false-positives.
>>
>> Testcase stdio-common/tst-fwrite-bz29459.c was fixed in the same way in
>> 1b6f868625403d6b7683af840e87d2b18d5d7731
>> (Increase the amount of data tested in stdio-common/tst-fwrite-bz29459.c, 2025-02-14)
>>
>> Testcases stdio-common/tst-fwrite-bz29459.c and stdio-common/tst-fwrite-pipe.c
>> were introcued in 596a61cf6b51ce2d58b8ca4e1d1f4fdfe1440dbc
>> (libio: Start to return errors when flushing fwrite's buffer [BZ #29459], 2025-01-28)
>> ---
>> stdio-common/tst-fwrite-pipe.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/stdio-common/tst-fwrite-pipe.c b/stdio-common/tst-fwrite-pipe.c
>> index a6119125b2..ce1a92b384 100644
>> --- a/stdio-common/tst-fwrite-pipe.c
>> +++ b/stdio-common/tst-fwrite-pipe.c
>> @@ -27,7 +27,7 @@
>> /* Usually this test reproduces in a few iterations. However, keep a high
>> number of iterations in order to avoid return false-positives due to an
>> overwhelmed/slow system. */
>> -#define ITERATIONS 5000
>> +#define ITERATIONS 500000
>>
>> #define BUFFERSIZE 20
>>
>> @@ -71,7 +71,7 @@ do_test (void)
>> {
>> /* Ensure the string we send has a new line because we're dealing
>> with a lined-buffered stream. */
>> - const char *s = "hello\n";
>> + const char *s = "hello world\n";
>> size_t len = strlen (s);
>> int i;
>
> Looks okay, thanks.
Okay. Committed
Thanks,
Stefan
More information about the Libc-alpha
mailing list