[PATCH] manual: Document setlogmask as MT-safe.

Florian Weimer fweimer@redhat.com
Thu Feb 13 21:04:45 GMT 2025


* Carlos O'Donell:

> setlogmask(3) was made MT-safe in glibc-2.33 with the fix for
> bug 26100.
> ---
>  manual/syslog.texi | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/manual/syslog.texi b/manual/syslog.texi
> index 02f84d6e6f..90a6487c02 100644
> --- a/manual/syslog.texi
> +++ b/manual/syslog.texi
> @@ -498,10 +498,7 @@ The symbols referred to in this section are declared in the file
>  
>  @deftypefun int setlogmask (int @var{mask})
>  @standards{BSD, syslog.h}
> -@safety{@prelim{}@mtunsafe{@mtasurace{:LogMask}}@asunsafe{}@acsafe{}}
> -@c Read and modify are not guarded by syslog_lock, so concurrent changes
> -@c or even uses are undefined.  This should use an atomic swap instead,
> -@c at least for modifications.
> +@safety{@prelim{}@mtsafe{}@asunsafe{}@acsafe{}}
>  
>  @code{setlogmask} sets a mask (the ``logmask'') that determines which
>  future @code{syslog} calls shall be ignored.  If a program has not

Looks good.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian



More information about the Libc-alpha mailing list