[PATCH v2] atomic: Reinstate HAVE_64B_ATOMICS configure check
Adhemerval Zanella Netto
adhemerval.zanella@linaro.org
Wed Dec 17 19:34:50 GMT 2025
On 17/12/25 15:58, Wilco Dijkstra wrote:
> Hi Adhemerval,
>
>
>> --- a/sysdeps/alpha/atomic-machine.h
>> +++ b/sysdeps/alpha/atomic-machine.h
>> @@ -15,11 +15,6 @@
>> License along with the GNU C Library. If not, see
>> <https://www.gnu.org/licenses/>. */
>>
>> -#ifndef _ALPHA_ATOMIC_MACHINE_H
>> -#define _ALPHA_ATOMIC_MACHINE_H
>> -
>> -#include_next <atomic-machine.h>
>> +#include <stdint.h>
>>
>> #define atomic_write_barrier() __asm ("wmb" : : : "memory");
>> -
>> -#endif
>
>> I am not sure what we gain by removing the include guards here.
>
> I think that is due to the revert having that change, so reverting the revert
> removes it. We can keep the guard.
>
>
>> -#ifndef _SPARC_ATOMIC_MACHINE_H
>> -#define _SPARC_ATOMIC_MACHINE_H 1
>
>> It is not clear why you need to change the include guards name here.
>
> Same here.
>
>> diff --git a/sysdeps/unix/sysv/linux/sparc/sparc32/Makefile b/sysdeps/unix/sysv/linux/sparc/sparc32/Makefile
>> index 167307cc78a95e86fa6f06ead1feb906980d361b..88b1383dbb5a203f33a61e66fda0606be1a1b1f2 100644
>> --- a/sysdeps/unix/sysv/linux/sparc/sparc32/Makefile
>> +++ b/sysdeps/unix/sysv/linux/sparc/sparc32/Makefile
>> @@ -11,7 +11,7 @@ endif
>>
>> # When I get this to work, this is the right thing
>> ifeq ($(subdir),elf)
>> -CFLAGS-rtld.c += -mcpu=v8
>> +#CFLAGS-rtld.c += -mcpu=v8
>> #rtld-routines += dl-sysdepsparc
>> endif # elf
>>
>
>> Hum, is this a leftover from development?
>
> This is an ancient hack from 1997 that doesn't work (it overrides -mcpu=leon3 which
> then causes assertions). I could remove it all since it has no explanation as to why it
> was needed then.
Right, do you need it because otherwise possible 64-bit atomic usage
trigger some assertation building against leon3?
More information about the Libc-alpha
mailing list