[PATCH] nptl: tests: Fix test-wrapper use in tst-dl-debug-tid.sh
Frederic Berat
fberat@redhat.com
Mon Dec 1 14:25:18 GMT 2025
On Mon, Dec 1, 2025 at 1:50 PM Yury Khrustalev <yury.khrustalev@arm.com>
wrote:
> On Mon, Dec 01, 2025 at 01:42:26PM +0100, Frederic Berat wrote:
> > On Mon, Dec 1, 2025 at 11:53 AM Yury Khrustalev <yury.khrustalev@arm.com
> >
> > wrote:
> >
> > > Test wrapper script was used twice: once to run the test
> > > command and second time within the text command which
> > > seems unnecessary and results in false errors when running
> > > this test.
> > >
> > > Fixes 332f8e62afef53492dd8285490bcf7aeef18c80a
> > >
> >
> > Looks good to me.
> > Although I'm not sure that the fact that I tested it is relevant as I
> > didn't get failures with the previous version.
>
> Did you use a test wrapper with ssh by any chance? The full command
>
I run my build/test in a dedicated container through `make check` and `make
test t=...`
> looked like it would use test wrapper without env to call test wrapper
> with env, and the second invocation would try to ssh into the same host.
> I guess it would work if this host knows the hostname used in the
> wrapper command, but I don't think we need to ssh again for this test.
>
And I agree, I modified this a few times during the development, I probably
made some mess in the way.
>
> > Reviewed-by: Frédéric Bérat <fberat@redhat.com>
>
> Thanks!
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://sourceware.org/pipermail/libc-alpha/attachments/20251201/b452c065/attachment.htm>
More information about the Libc-alpha
mailing list