[PATCH v2] Don't use -Wfree-labels/-Wmissing-parameter-name if unsupported
Sam James
sam@gentoo.org
Sat Aug 23 01:47:44 GMT 2025
"H.J. Lu" <hjl.tools@gmail.com> writes:
> Don't use -Wfree-labels/-Wmissing-parameter-name for "make check" if
> they are unsupported by TEST_CC.
>
> This fixes BZ #33310.
>
> Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
> ---
> Makefile.in | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Makefile.in b/Makefile.in
> index 189c1ac778..61a414dd4d 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -6,6 +6,8 @@ test-cc-option-wimplicit-fallthrough = @libc_cv_test_cc_wimplicit_fallthrough@
> test-config-cflags-mprefer-vector-width = @libc_cv_test_cc_mprefer_vector_width@
> test-config-cflags-signaling-nans = @libc_cv_test_cc_signaling_nans@
> test-config-cflags-wno-ignored-attributes = @libc_cv_test_wno_ignored_attributes@
> +test-cc-option-wfree-labels = @libc_cv_test_cc_wfree_labels@
> +cc-option-wmissing-parameter-name =
> @libc_cv_test_cc_wmissing_parameter_name@
Why aren't these two consistent? Shouldn't both be test-cc-* = ...?
> test-enable-cet = @test_enable_cet@
> test-have-static-pie = @libc_cv_test_static_pie@
> test-supported-fortify = @libc_cv_test_supported_fortify_source@
> @@ -25,6 +27,8 @@ check xcheck test:
> config-cflags-mprefer-vector-width="$(test-config-cflags-mprefer-vector-width)" \
> config-cflags-signaling-nans="$(test-config-cflags-signaling-nans)" \
> config-cflags-wno-ignored-attributes="$(test-config-cflags-wno-ignored-attributes)" \
> + cc-option-wfree-labels="$(test-cc-option-wfree-labels)" \
> + cc-option-wmissing-parameter-name="$(test-cc-option-wmissing-parameter-name)" \
> enable-cet="$(test-enable-cet)" \
> have-static-pie="$(test-have-static-pie)" \
> supported-fortify="$(test-supported-fortify)" \
More information about the Libc-alpha
mailing list