[PATCHv2] malloc: Make sure tcache_key is odd enough

Samuel Thibault samuel.thibault@ens-lyon.org
Mon Aug 4 08:46:18 GMT 2025


Andreas Schwab, le lun. 04 août 2025 09:48:29 +0200, a ecrit:
> On Aug 03 2025, Samuel Thibault wrote:
> 
> > It is within 80 columns.
> 
> Nope.

??

The patch is not since it has a heading character, but the file
definitely is:

  /* We need tcache_key to be non-zero (otherwise tcache_double_free_verify's
     clearing of e->key would go unnoticed and it would loop getting called
     through __libc_free), and we want tcache_key not to be a commonly-occurring
     value in memory, so ensure a minimum amount of one and zero bits.  */

That's 80 columns.

Samuel


More information about the Libc-alpha mailing list